CESM to NOAA sync: restart filename#99
Open
iangrooms wants to merge 7 commits into
Open
Conversation
This rename avoids a build failure where the CESM infrastructure cannot locate halo_exchange.o due to the dot in the filename.
In stochy_data_mod the name of the ocean stochastic restart file is no longer hard-coded. Instead it has become a public module variable initialized to its previously hard-coded value. This enables other modules to change the name of the restart file. Together with PR 376 to NCAR/MOM6, this enables MOM6 to write the restart file in the run directory, with file name equal to the mom6 restart filename but with .r_stoch. in place of .r.. It also massively reduces the amount of output printed to the cesm log file, and corrects some copy/paste typos in the output. This partially addresses issue 360 on NCAR/MOM6 about not having exact restarts when using the stochastic GM+E parameterization.
Also print out stoch_restfile if the netcdf file open fails
Pulling in latest from NOAA-PSL before sending our updates to them.
pjpegion
reviewed
Jun 29, 2026
Collaborator
There was a problem hiding this comment.
Can you modify the reference to halo_exchange.fv3.F90 in CMakeLists.txt?
Contributor
Author
There was a problem hiding this comment.
Sorry - I went through and changed the name in all the references to this file, but I neglected to change the actual file name. Just renamed this file to have a . instead of an underscore.
pjpegion
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CESM needed to modify the restart filename for this stochastic physics package. On the NOAA-PSL repository it is hard-coded as
'./INPUT/ocn_stoch.res.nc'. This PR makes the stochastic restart filename a public module variable with the default value equal to'./INPUT/ocn_stoch.res.nc'. For non-CESM users of this package the change should have no impact at all, but the change allows CESM to 'use' the module variable and set it using our naming and location conventions.The PR also fixes some typos in comments.