moved React to peerDependencies list#12
Merged
Merged
Conversation
Contributor
|
Ah, good catch, sorry about that! We might be able to remove muppet entirely, not sure NWS Connect has plans to use it, but until then this is the right move. |
mackenzie-grimes-noaa
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
package.jsonChanges
ReactfromdependenciestopeerDependenciesand allowed version 19Explanation
Muppet installs its own instance of React because it is listed in the
dependencies. This causesed version conflicts in consuming projects that didn't also use React v18.By moving to
peerDependencies, muppet won't install its own instance and will instead rely on the consuming project.