Skip to content

[wafs_v7.1]GFIP: Fix runtime error of 'floating invalid' if compiling in debug mode with 'check all' option.#1561

Open
YaliMao-NOAA wants to merge 2 commits into
NOAA-EMC:release/wafs_v7.1from
YaliMao-NOAA:release/wafs_v7.1
Open

[wafs_v7.1]GFIP: Fix runtime error of 'floating invalid' if compiling in debug mode with 'check all' option.#1561
YaliMao-NOAA wants to merge 2 commits into
NOAA-EMC:release/wafs_v7.1from
YaliMao-NOAA:release/wafs_v7.1

Conversation

@YaliMao-NOAA

@YaliMao-NOAA YaliMao-NOAA commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

This is a fix for GFIP.
Fix runtime error of 'floating invalid' if compiling in debug mode with 'check all' option.

One of the fix is about 'moistInt'. It is a module member and shared by all subrountines in the module and should not be re-defined and made private in subroutine icing_sev

Fix runtime error of 'floating invalid' if compiling in debug mode wi…
65345b7 
…th 'check all' option.

One of the fix is about 'moistInt'. It is a module member and shared by all subrountines
in the module and should not be re-defined and made private in subroutine icing_sev
@YaliMao-NOAA YaliMao-NOAA mentioned this pull request Jun 15, 2026
Open
WenMeng-NOAA
WenMeng-NOAA reviewed Jun 15, 2026
View reviewed changes
Comment thread sorc/ncep_post.fd/GFIP3.f
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Jun 15, 2026
@WenMeng-NOAA WenMeng-NOAA changed the title GFIP: Fix runtime error of 'floating invalid' if compiling in debug mode with 'check all' option. [wafs_v7.1]GFIP: Fix runtime error of 'floating invalid' if compiling in debug mode with 'check all' option. Jun 15, 2026
@WenMeng-NOAA WenMeng-NOAA linked an issue Jun 15, 2026 that may be closed by this pull request
Runtime errors when running WAFS UPP if compiling in debug mode with "-check all -ftrapuv" #1560
Open
@WenMeng-NOAA

WenMeng-NOAA commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

@YaliMao-NOAA To fix the debug issue, is an update to the post_gtg hash needed?
Somehow, I still get errors with the debug mode enabled :

nid001249.dogwood.wcoss2.ncep.noaa.gov 143: forrtl: error (65): floating invalid
Image              PC                Routine            Line        Source             
upp.x              0000000002F8FF7B  Unknown               Unknown  Unknown
libpthread-2.31.s  0000145826291910  Unknown               Unknown  Unknown
upp.x              0000000001E1002D  gtg_read_config_          807  gtg_read_config.F90
upp.x              0000000001D020CB  gtg_algo_                 717  gtg_algo.F90
upp.x              000000000196C5C5  mdlfld_                  4314  MDLFLD.f
upp.x              0000000000B40B1B  process_upp_mod_m          78  PROCESS.f
upp.x              000000000072CE86  MAIN__                    731  WRFPOST.F

@YaliMao-NOAA

YaliMao-NOAA commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA You are right about the runtime error which occurs in GTG code, not GFIP. This PR is for GFIP fix.

I have the fix for GTG code and am proposing two solutions to NCAR team. Once confirmed with the solution, I will open another PR for GTG and close this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA left review comments
@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

Assignees

No one assigned

Labels

Ready for Review This PR is ready for code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Runtime errors when running WAFS UPP if compiling in debug mode with "-check all -ftrapuv"

2 participants

@YaliMao-NOAA @WenMeng-NOAA