Updates for ccpp-capgen v1#1221
Open
climbfuji wants to merge 18 commits into
Open
Conversation
* Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * only have DTC/SCM people in the CODEOWNERS for the scm/dev branch --------- Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
… NOAA fixes) (NCAR#1209) * Read and broadcast data from MPI root rank during init and timestep init phase in GFS time vary; add time vary interstitials for NEPTUNE (NCAR#1187) * 1. number_of_coefficients_in_ozone_data --> number_of_coefficients_in_ozone_forcing_data 2. Add NEPTUNE interstitials in physics/Interstitials/UFS_SCM_NEPTUNE/ * Read and broadcast data in CCPP init and timestep_init phases instead of reading with every MPI rank * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * physics/tools/mpiutil.F90: add temporary routine to mpi-abort the model if MPI broadcast errors occur * Bug fixes in physics/Interstitials/UFS_SCM_NEPTUNE/GFS_time_vary_pre.*.F90 when writing to errmsg for invalid w3kindreal/w3kindint; additionally: formatting updates * In physics/Radiation/radiation_astronomy.f, replace hardcoded zero with mpiroot; move mpiutil.F90 to subdirectory tools * Add ability to build with ip if it is found. sp is being replaced by ip so this is needed. Note that in spack-stack 1.9.3 the ip package builds with the OpenMP flag, so CMAKE_Fortran_FLAGS_OPENMP_OFF needs to be set by the host model. The RRTMGP files currently break if compiled with OpenMP flags. * update several files to work with CCPP SCM after PR 1187 * remove ccpp_bcast for aerin and aer_pres due to UFS RT hanging --------- Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com> Co-authored-by: Soren Rasmussen <s.c.rasmussen@gmail.com>
Main -> scm/dev (20260421)
…r_Aligo/mp_fer_hires.meta
…: fix intent for xlat_d and xlon_d
…eature/capgen-ng
This was referenced May 29, 2026
…eature/capgen-ng
…and mp_nssl.{F90,meta}
…_NEPTUNE/GFS_rrtmgp_pre.meta
climbfuji
force-pushed
the
feature/capgen-ng
branch
from
34d28ce to
bc76b77
Compare
13 tasks
climbfuji
changed the title
climbfuji
requested review from
cenlinhe,
dustinswales,
grantfirl,
rhaesung and
tanyasmirnova
as code owners
climbfuji
requested review from
AndersJensen-NOAA,
mdtoyNOAA and
mjiacono
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for
scm/devand makes the necessary changes to the CCPP metadata and Fortran files to support the transition to the new code generator ccpp-capgen v1.The majority of the changes are addressing inconsistencies between Fortran and Metadata, the renaming of
*_finalizeto*_final, missing dependencies in the metadata tables, and simplified syntax for defining DDTs in the metadata.Testing
Dependencies