Remove verticalLoop suite object#731
Merged
Merged
Conversation
peverwhee
requested changes
Mar 30, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
thanks for doing this, @dustinswales !
Just a couple more things that can be removed.
peverwhee
approved these changes
Apr 7, 2026
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
thanks @dustinswales !
…est/temp_adjust.F90
…host_test/temp_adjust.F90
climbfuji
approved these changes
Apr 7, 2026
Collaborator
|
@gold2718 Do you have time to review this? |
gold2718
approved these changes
Apr 13, 2026
gold2718
left a comment
gold2718
left a comment
Collaborator
There was a problem hiding this comment.
This looks great (and with less code for a change), thanks!
Collaborator
|
@mkavulich This can be merged I believe |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the VerticalLoop Suite object from Capgen.
Also, update tests that were using VerticalLoop to explicitly use vertical dimension in Scheme
User interface changes?:
No
Fixes:
#729