Bug fix for XML schema 2.0: require valid Fortran IDs for schemes, groups, and suites#730
Merged
climbfuji merged 9 commits intoApr 14, 2026
Conversation
…ran_id_type for scheme, group, and suite names
climbfuji
force-pushed
the
bugfix/valid_fortran_id_for_scheme_group_suite_names
branch
from
b3e41ef to
9b7dbff
Compare
climbfuji
changed the title
mkavulich
approved these changes
Apr 2, 2026
mkavulich
left a comment
mkavulich
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks for this fix!
climbfuji
commented
Apr 2, 2026
dustinswales
approved these changes
Apr 7, 2026
Collaborator
Author
|
@gold2718 This is also ready for your review |
gold2718
requested changes
Apr 13, 2026
gold2718
left a comment
gold2718
left a comment
Collaborator
There was a problem hiding this comment.
I have one question and a suggestion / request to use more explanatory filenames for testing.
gold2718
approved these changes
Apr 14, 2026
gold2718
left a comment
gold2718
left a comment
Collaborator
There was a problem hiding this comment.
There is a(n optional) typo fix but otherwise, this looks okay.
| exc_strings = [ | ||
| "The value 'scheme-1' is not accepted by the pattern '[A-Za-z][A-Za-z0-9_]{0,63}", | ||
| "The value 'group-1' is not accepted by the pattern '[A-Za-z][A-Za-z0-9_]{0,63}", | ||
| "he value 'ver-test-suite' is not accepted by the pattern '[A-Za-z][A-Za-z0-9_]{0,63}", |
Collaborator
There was a problem hiding this comment.
Just noticed the typo here. he test is still valid but it roubles the soul.
climbfuji
commented
Apr 14, 2026
Collaborator
Author
|
@mkavulich This can now be merged |
climbfuji
deleted the
bugfix/valid_fortran_id_for_scheme_group_suite_names
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix for XML schema 2.0: require valid Fortran IDs for schemes, groups, and suites
This PR introduces
fortran_id_type_uniqueinschema/suite_v2.0.xsdand requires eitherfortran_id_type_uniqueor the existingfortran_id_typefor scheme, group, and suite names depending on the context. For nested suite elements, duplicates are allowed, what matters is that the final suite -- after recursive substitution of the nested suite constructs -- contains no duplicates. The PR also adds unit tests for catching invalid Fortran IDs.User interface changes? No: Scheme, group and suite names that weren't Fortran IDs were never allowed. Without this PR, they would lead to compilation errors for the auto-generated caps.
Fixes #723
Testing: all pass
test removed: n/a
unit tests: added unit tests to check for valid Fortran identifiers for schemes, groups, and suites
system tests:
manual testing: