Capgen in SCM: DDT subfields into Group Caps#640
Merged
climbfuji merged 23 commits intoMay 22, 2025
Conversation
… bugfix/allow_mod_filenames
dustinswales
requested review from
climbfuji,
gold2718,
grantfirl,
mkavulich,
mwaxmonsky and
peverwhee
as code owners
Collaborator
|
Since this is built on top of #637, I'll wait with reviewing until that PR is merged |
… bugfix/full_array_ref_in_host_cap
mkavulich
changed the title
… bugfix/allow_mod_filenames
…nswales/ccpp-framework into bugfix/full_array_ref_in_host_cap
…/ccpp-framework into bugfix/full_array_ref_in_host_cap
… bugfix/full_array_ref_in_host_cap
dustinswales
changed the title
… bugfix/full_array_ref_in_host_cap
peverwhee
reviewed
May 22, 2025
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
one small testing question!
Member
Author
|
@climbfuji @peverwhee @gold2718 |
peverwhee
approved these changes
May 22, 2025
peverwhee
left a comment
peverwhee
left a comment
Collaborator
There was a problem hiding this comment.
thanks @dustinswales !
climbfuji
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow for sub components of a DDT to be passed into the Group caps from the Host cap .
Description
This PR adds recursive searching for DDTs when creating the call strings to the Group caps. This preserves the full reference in the call string.
Snippet from
test_host_ccpp_cap.F90before the change to ddt_library.py:sfc_up_sw=phys_state%sfc_up_sw(col_start:col_end)After, with full reference in call string:
sfc_up_sw=phys_state%fluxSW%sfc_up_sw(col_start:col_end)User interface changes?: No
Fixes: #639
This is built on #646
Testing:
New testing added to pass subfields of DDT into scheme.