fix: include CSS/SCSS files in lefthook stylelint glob#1981
Open
lunasilvestre wants to merge 1 commit intoNASA-IMPACT:mainfrom
Open
fix: include CSS/SCSS files in lefthook stylelint glob#1981lunasilvestre wants to merge 1 commit intoNASA-IMPACT:mainfrom
lunasilvestre wants to merge 1 commit intoNASA-IMPACT:mainfrom
Conversation
The stylelint pre-commit hook only matched JS/TS files, so changes to .scss or .css files in src/styles/ would skip the stylelint check entirely. Add scss and css extensions to the glob pattern.
👷 Deploy request for veda-ui pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: N/A
Description of Changes
The stylelint pre-commit hook glob only matched
*.{js,ts,jsx,tsx}, so staging.scssor.cssfiles would skip the stylelint check entirely. Addedscssandcssextensions to the glob pattern.Notes & Questions About Changes
yarn lint:cssscript already covers.scssfiles via its own glob patterns — this fix ensures the pre-commit hook actually triggers for stylesheet changesValidation / Testing
sync hooks: ✔️)