fix: remove unconditional debug console.log in raster-timeseries#1979
Open
lunasilvestre wants to merge 2 commits intoNASA-IMPACT:mainfrom
Open
fix: remove unconditional debug console.log in raster-timeseries#1979lunasilvestre wants to merge 2 commits intoNASA-IMPACT:mainfrom
lunasilvestre wants to merge 2 commits intoNASA-IMPACT:mainfrom
Conversation
Remove a console.log(error) that was left in production code with the comment "Temporarily turning on log for debugging". The conditional debug logging behind the LOG flag is preserved.
The error variable became unused after removing the debug console.log. Use catch-without-binding since the error is not referenced.
👷 Deploy request for veda-ui pending review.Visit the deploys page to approve it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Ticket: N/A
Description of Changes
Remove a
console.log(error)left in production code with the comment "Temporarily turning on log for debugging". The conditional debug logging behind theLOGflag is preserved. Also switch to catch-without-binding since the error variable is no longer referenced.Notes & Questions About Changes
if (LOG) console.log(...)statements are intentionally kept — only the unconditional one is removedValidation / Testing
no-unused-varswarning)