Skip to content

MCR-3719 Transition property.xsl to a pure XSLT3 environment#2972

Open
toKrause wants to merge 1 commit into
mainfrom
issues/MCR-3719_Transition-property-xsl-to-a-pure-XSLT3-environment
Open

MCR-3719 Transition property.xsl to a pure XSLT3 environment#2972
toKrause wants to merge 1 commit into
mainfrom
issues/MCR-3719_Transition-property-xsl-to-a-pure-XSLT3-environment

Conversation

@toKrause

@toKrause toKrause commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Link to jira.

Pull Request Checklist (Author)

Please go through the following checklist before assigning the PR for review:

Ticket & Documentation

  • The issue in the ticket is clearly described and the solution is documented.
  • Design decisions (if any) are explained.
  • The ticket references the correct source and target branches.
  • The fixed-version is correctly set in the ticket and matches the PR's target branch (main).

Feature & Improvement Specific Checks

  • Instructions on how to test or use the feature are included or linked (e.g. to documentation).
  • For UI changes: before & after screenshots are attached.
  • New features or migrations are documented.
  • Does this change affect existing applications, data, or configurations?
    • Yes: Is a migration required? If yes, describe it.
    • Breaking change is marked in the commit message.

usage of mcrproperty:one needs to be replaced with mcrproperty:get
usage of mcrproperty:all needs to be replaced with mcrproperty:map

Testing

  • I have tested the changes locally.
  • The feature behaves as described in the ticket.
  • Were existing tests modified?
    • Yes: explain the changes for reviewers.

MCR Conventions & Metadata

  • MCR naming conventions are followed
  • If the public API has changed:
    • Old API is deprecated or a migration is documented.
    • If not, no action needed.
  • Java license headers are added where necessary.
  • Javadoc is written for non-self-explanatory classes/methods (Clean Code).
  • All configuration options are documented in Javadoc and mycore.properties.
  • No default properties are hardcoded — all set via mycore.properties.

Multi-Repo Considerations

  • Is an equivalent PR in MIR required?
    • If yes, is it already created?

To be used in conjunction with MyCoRe-Org/mir#1387.

@toKrause toKrause force-pushed the issues/MCR-3719_Transition-property-xsl-to-a-pure-XSLT3-environment branch 2 times, most recently from 345d170 to 4a1c811 Compare June 19, 2026 11:03
@toKrause toKrause force-pushed the issues/MCR-3719_Transition-property-xsl-to-a-pure-XSLT3-environment branch from 4a1c811 to fb5edac Compare July 6, 2026 12:50
@toKrause toKrause removed the postponed label Jul 6, 2026

@sebhofmann sebhofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing dead code like mcrproperty:all is fine.

Introducing a breaking change just for an esthetic change (renaming one to get) is to much.

@toKrause

toKrause commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Introducing a breaking change just for an esthetic change (renaming one to get) is to much.

If the mid-term goal is to remove top-level-xsl:param with function-calls, we should, imho, clean this up now, before the function is widely used.

We could add get as an additional function and remove one in the next release, giving people some time to migrate, like we do with the Java-code. But, afaik, there is no way to mark a XSLT function as "deprecated".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants