Use constant-time string comparison in verifyNotification#17
Merged
danielcivit merged 2 commits intoMultiSafepay:masterfrom Aug 21, 2025
Merged
Use constant-time string comparison in verifyNotification#17danielcivit merged 2 commits intoMultiSafepay:masterfrom
verifyNotification#17danielcivit merged 2 commits intoMultiSafepay:masterfrom
Conversation
Member
|
Hello @CasEbb Thanks for submitting this contribution. Replacing the direct string comparison with hash_equals() is a great security enhancement, as you explained, we understand it prevents potential timing attacks during hash verification. We will be processing a new release soon that will include this change. |
danielcivit
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a possible timing attack in
Notification::verifyNotification().The two hashes are compared using simple string comparison which is susceptible to timing attacks. It is replaced with the constant-time
hash_equals()function.