Migrate the rest of common components#1318
Merged
Merged
Conversation
|
Preview deployed: https://preview-1318.staging.documentcloud.org |
Collaborator
Author
|
It looks like Chromatic can't load document assets. I wonder if we blocked its crawler. |
mitchelljkotler
requested changes
May 6, 2026
Member
mitchelljkotler
left a comment
mitchelljkotler
left a comment
There was a problem hiding this comment.
I asked Claude to review - it identified a few issues, but I am not familiar enough with Svelte to tell if they are real. Feel free to ignore if these are not relevant.
mitchelljkotler
approved these changes
May 12, 2026
This was referenced May 12, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1233, #1241, #1198, #854
Button.svelte- touches anything with a button andon:clickFlex.svelte- including switching to use classes instead of inline stylesNavItem.svelte- this touches a lotPremium.sveltePin.svelteTip.svelte- very widely used