Clamped color gradient [Volinga]#1394
Open
Ediolot wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the backward-pass gradient gating for clamped colors in the FastGS rasterization training kernel so that Gaussians with strongly negative SH0-derived colors can still receive gradients and recover from black, while preserving the existing forward-pass clamp behavior.
Changes:
- Modifies the backward-pass
color_grad_factorso gradients are only blocked aboveconfig::max_blend_color, not below 0. - Keeps the forward-pass color clamp to
[0, config::max_blend_color]unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found the following behaviour where gaussians with a strongly negative SH0 color will stop updating their colors. Colors outside
[0, max_blend_color]get a 0 gradient factor and can never climb out of black leaving permanently dark gaussians. The issue seems to be mitigated (and hidden) since position, scale, rotation and opacity are still updated.This fix changes the clamp on the gradient for the backward pass (forward still clamps as before).
I also ran a few fast tests on the truck dataset (MCMC, 500K splats, 10K iter, resize factor = 2). There are no big changes to the naked eye but the average loss seems to be better. All runs took a similar amount of time.