Added japanese support - #104
Conversation
| } | ||
| } | ||
| char *argv_title[] = {title, system_name}; | ||
| if (!strncmp(lang, "ja_JP", 5)) { |
There was a problem hiding this comment.
Spliting title into title_pre & title_suf may be better.
There was a problem hiding this comment.
Spliting
titleintotitle_pre&title_sufmay be better.
OK. I did that in the commit 1c44d63.
|
This seems to mess with the order of the words (symbols?) in the Chinese translations. |
No problem with the order. The order of Japanese phrases is opposite of Chinese and English, so I suggest splitting |
Okay, but that's not what I'm saying. When I tested, this PR changed the order of the Chinese translations, when its only meant to change Japanese |
|
It looks like no problem with the order on my device
|
it seems impossible. Could you please provide at least one screenshot and tell me how did you install the fork? Thanks a lot. |
| {"zh_CN", "激活 ", "", "转到“设置”以激活 ", "。"}, | ||
| {"zh_TW", "啟用 ", "", "移至[設定]以啟用 ", "。"}, | ||
| {"zh_HK", "啟用 ", "", "移至[設定]以啟用 ", "。"}, | ||
| {"ja_JP", "", " をアクティブ化", "「システム環境設定」 ", "をアクティブ化に行ってください。"}, |
There was a problem hiding this comment.
| {"ja_JP", "", " をアクティブ化", "「システム環境設定」 ", "をアクティブ化に行ってください。"}, | |
| {"ja_JP", SYSTEM_NAME" をアクティブ化", "「システム環境設定」 "SYSTEM_NAME"をアクティブ化に行ってください。"}, |
@onion108 with current i18n.c structure there is no need to suffer with string builder. Just rebase to master and add your text again :)
Also, you may add (not more than one) newline in second string if it is needed :)
Also also, I found different activation text on Japanese~
| i18n_info i18n_map[] = { | ||
| // Must be first, used as default | ||
| {"en_US", "Activate "SYSTEM_NAME, "Go to Settings to activate "SYSTEM_NAME"."}, | ||
| {"en_US", "Activate "SYSTEM_NAME, "Go to Settings to activate " SYSTEM_NAME "."}, |
There was a problem hiding this comment.
Can you please remove spaces here and in 20th line? There is no need to put em on random places ^^
There was a problem hiding this comment.
i know but, my apple clang told me that unless I do this, it wouldn't be happy
There was a problem hiding this comment.
#107 A formatter is on coming so I think it's ok
5 participants
No description provided.