Skip to content

Propagate CDAssociation modifiers to the respective role symbols #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jra-se wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Propagate CDAssociation modifiers to the respective role symbols #98

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
497accd
propagate derived association modifiers to both CDRoleSymbols
jra-se May 22, 2026
6a7852a
spotlessApply
jra-se May 23, 2026
6ae74e7
expand modifier override to all association modifiers
jra-se May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions .../main/java/de/monticore/cdassociation/_symboltable/CDAssociationSymbolTableCompleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void initialize_CDRole(CDRoleSymbol symbol, ASTCDAssociation ast, boolean
}
symbol.setType(typeResult.get());

setupModifiers(side.getModifier(), symbol);
setupModifiers(side.getModifier(), ast.getModifier(), symbol);

symbol.setIsDefinitiveNavigable(isLeft ? ast.getCDAssocDir().isDefinitiveNavigableLeft() : ast
.getCDAssocDir().isDefinitiveNavigableRight());
Expand Down Expand Up @@ -144,13 +144,14 @@ public void endVisit(ASTCDAssociation node) {
}
}

public void setupModifiers(ASTModifier modifier, CDRoleSymbol roleSymbol) {
roleSymbol.setIsPublic(modifier.isPublic());
roleSymbol.setIsPrivate(modifier.isPrivate());
roleSymbol.setIsProtected(modifier.isProtected());
roleSymbol.setIsStatic(modifier.isStatic());
roleSymbol.setIsFinal(modifier.isFinal());
roleSymbol.setIsDerived(modifier.isDerived());
public void setupModifiers(ASTModifier assocSideModifier, ASTModifier assocModifier,
CDRoleSymbol roleSymbol) {
roleSymbol.setIsPublic(assocSideModifier.isPublic() || assocModifier.isPublic());
roleSymbol.setIsPrivate(assocSideModifier.isPrivate() || assocModifier.isPrivate());
roleSymbol.setIsProtected(assocSideModifier.isProtected() || assocModifier.isProtected());
roleSymbol.setIsStatic(assocSideModifier.isStatic() || assocModifier.isStatic());
roleSymbol.setIsFinal(assocSideModifier.isFinal() || assocModifier.isFinal());
roleSymbol.setIsDerived(assocSideModifier.isDerived() || assocModifier.isDerived());
}

public static void addRoleToTheirType(CDRoleSymbol symbol, TypeSymbol otherType) {
Expand Down
Loading