Expose minDistance scalar UDFs#135
Open
estebanzimanyi wants to merge 3 commits into
Open
Conversation
Registers minDistance(tgeompoint, geometry), minDistance(geometry, tgeompoint), and minDistance(tgeompoint, tgeompoint) following the nearestApproachDistance pattern. The geo-typed forms reuse the NAD kernel since NAD reduces to spatial-min when one argument has no time dimension; the tgeompoint/tgeompoint form calls the threshold-aware mindistance_tgeo_tgeo kernel. The canonical cross-join shape is MIN(minDistance(t1, t2)) with GROUP BY, the cloud-SQL-natural Solution-2 form; MobilityDB exposes the same signature as a 2-ary aggregate and yields identical results. Advances the MEOS vcpkg pin one commit over the base branch to d4cc7d289 so the mindistance kernels are present; that commit only adds mindistance_tgeo_tgeo and tgeoarr_tgeoarr_mindist and changes no existing signature.
Member
Author
Reviewer's quickstart — ~2-3 minutesWhat this PR does: Expose minDistance scalar UDFs. Risk: focused, single-purpose. Spot-check the source diff + matching tests; CI confirms. Cross-link: Linux arm64 CI here needs #161 for the orthogonal |
`meosType` (lower-case) is the **pre-consolidation** MEOS type name; `MeosType` (upper-case) is the **post-consolidation** target that the upstream rename sweep has not yet reached. The current vcpkg pin (`vcpkg_ports/meos/portfile.cmake` REF f11b7443ee98…) is still pre-consolidation: `meos/include/temporal/meos_catalog.h` line 121 declares the typedef as `} meosType;` and every MEOS API uses the lower-case spelling. MobilityDuck's source code consistently uses `meosType` to match — `grep -rn '\bMeosType\b' src/` finds the name only on the alias line and its comment, nowhere else. c8cad6d added `using meosType = MeosType;` as a forward-looking bridge for the eventual consolidation bump. That bridge points at `MeosType`, which the current pin does NOT yet expose, so it breaks every PR's Linux arm64 build with: /duckdb_build_dir/src/include/tydef.hpp:18:18: error: ‘MeosType’ does not name a type; did you mean ‘meosType’? The fix is to drop the premature alias and replace the misleading comment with one that documents the pre/post-consolidation distinction and the resume path for the next pin bump — at that point a reviewer can either restore the bridge (this time it'll be valid because `MeosType` will exist) or sweep the MobilityDuck source from `meosType` to `MeosType` in a single PR. Unblocks every in-flight PR's Linux arm64 build: #126, #130, #149, #158, #159, #160, plus the entire `feat/*_port_core` extended-type stack (#148/#150/#151/#153/#155/#156).
The stage_icu helper mapped only the Linux uname values, so on the macOS arm64 test runner uname -m returned "arm64" and the icu extension was copied to .duckdb/extensions/v1.4.4/arm64 instead of .../osx_arm64, where DuckDB's autoload looks. The hub fallback is not reliably resolvable on that runner, so the osx_arm64 Test step failed to load the extension. Map the OS and architecture to the DuckDB platform string (linux_amd64, linux_arm64, osx_amd64, osx_arm64) so the locally built icu is staged at the path autoload expects on every tested platform; the Linux mapping is unchanged. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers minDistance(tgeompoint, geometry), minDistance(geometry, tgeompoint), and minDistance(tgeompoint, tgeompoint) following the nearestApproachDistance pattern. The geo-typed forms reuse the NAD kernel since NAD reduces to spatial-min when one argument has no time dimension; the tgeompoint/tgeompoint form calls the threshold-aware mindistance_tgeo_tgeo kernel. The canonical cross-join shape is MIN(minDistance(t1, t2)) with GROUP BY, the cloud-SQL-natural Solution-2 form, identical in result to the MobilityDB 2-ary aggregate of the same signature. Stacked on the MEOS pin bump branch; advances the pin one further commit to d4cc7d289 so the mindistance kernels are present, a commit that only adds mindistance_tgeo_tgeo and tgeoarr_tgeoarr_mindist and changes no existing signature.