Skip to content

fix(oauth): trim GitHub OAuth client id and secret from env #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jony376 wants to merge 2 commits into from
Closed

fix(oauth): trim GitHub OAuth client id and secret from env #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a249e9c
fix(oauth): trim GitHub OAuth client id and secret from env
jony376 May 29, 2026
9ce571b
Merge branch 'main' into fix/oauth-env-trim
MkDev11 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/app/api/auth/github/callback/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ function err(req: NextRequest, code: string): NextResponse {
}

export async function GET(req: NextRequest) {
const clientId = process.env.GITHUB_OAUTH_CLIENT_ID;
const clientSecret = process.env.GITHUB_OAUTH_CLIENT_SECRET;
const clientId = process.env.GITHUB_OAUTH_CLIENT_ID?.trim();
const clientSecret = process.env.GITHUB_OAUTH_CLIENT_SECRET?.trim();
if (!clientId || !clientSecret) return err(req, 'oauth_not_configured');

const code = req.nextUrl.searchParams.get('code');
Expand Down
2 changes: 1 addition & 1 deletion src/app/api/auth/github/login/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ const NEXT_COOKIE = 'gh_oauth_next';
const STATE_MAX_AGE_SEC = 600; // 10 min — plenty for the round-trip

export async function GET(req: NextRequest) {
const clientId = process.env.GITHUB_OAUTH_CLIENT_ID;
const clientId = process.env.GITHUB_OAUTH_CLIENT_ID?.trim();
if (!clientId) {
return NextResponse.json({ error: 'GITHUB_OAUTH_CLIENT_ID not set' }, { status: 500 });
}
Expand Down