Calculate PV for single person with a disabled child, considering mortality of said child.

[brian-courts]

I've been working on these changes for a while, and hadn't checked to see that you have made some significant changes to your program. If you think the changes are appropriate, I can re-make them, starting with your revised programs, and work on the required changes for a couple. I added the maxAge property for person, per their mortality table, then removed it, since we currently test to age 115 in all cases.

[MikePiper]

Hi Brian. Thank you once again for another contribution. Yes, I made some pretty significant code additions/changes over the last several weeks, to provide functionality for people who are already widows/widowers when using the calculator (including functionality for mother/father benefits, as applicable). As far as accounting for mortality for adult disabled children, I agree that it's useful, with the biggest impact being preventing the total PV from being significantly overstated. What has always stopped me is the idea of how bewilderingly complicated benefit.service.calculateMonthlyPaymentsCouple() would become. (Rather than 4 possible mortality situations, we'd have 8 -- or as many as 64 if we continue to allow for up to four children.) It seems like we'd have to just come up with some completely different way of doing it, and I have always been stumped on such. But if you think you have a way of attacking the problem, don't let me get in your way! On an unrelated note, I hear all the time from people about how helpful the Range output is.

…

-Mike

On Wed, Sep 23, 2020 at 6:02 PM Brian Courts ***@***.***> wrote: I've been working on these changes for a while, and hadn't checked to see that you have made some significant changes to your program. If you think the changes are appropriate, I can re-make them, starting with your revised programs, and work on the required changes for a couple. ------------------------------ You can view, comment on, or merge this pull request online at: #23 Commit Summary - Merge pull request #2 from MikePiper/master - Added maxAge property to Person - Revise determineMortalityTable to set person's mortalityTable and maxAge properties - Reducing console.log output for testing - Revised probability alive calc. for single person - For disabled child single parent - Adjustments 1 - Revisions disabled child 2020_08_20 - Modified presentvalue.service tests - Minor changes - Added test: adult disabled plus young non-disabled - Updating with log output - Update single person targets - Update to passing single person w/ disabled child - Removed console.log's for single person File Changes - *M* karma.conf.js <https://github.com/MikePiper/open-social-security/pull/23/files#diff-a2a3b7b0c9c3b4b93b4aebf4e3ec3cfb> (8) - *M* src/app/benefit.service.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-859711f01fdccf7488c1228634b809c9> (94) - *M* src/app/data model classes/calculationscenario.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-e5729d5aa9705d5d4fd60f0d6ff64458> (3) - *M* src/app/data model classes/calculationyear.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-a92a2d40de57d23d0e81d548288ab43c> (17) - *M* src/app/data model classes/person.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-00484ca41014d991140cbea3d59d5456> (1) - *M* src/app/earningstest.service.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-29736c500f1b7bbb805f373d923946d9> (49) - *M* src/app/familymaximum.service.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-a1efb9fcacf6dd36dea0504b2693bcdd> (5) - *M* src/app/home/home.component.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-e243ddc850b18eaabb654d8813bb32fb> (4) - *M* src/app/mortality.service.spec.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-10b9baf8bd5ec28485379085c5faf59d> (19) - *M* src/app/mortality.service.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-795283ab9625449415fd5b5a52535265> (1056) - *M* src/app/presentvalue.service.spec.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-bc1c9ae77602844324c2f9e6653cf50c> (373) - *M* src/app/presentvalue.service.ts <https://github.com/MikePiper/open-social-security/pull/23/files#diff-f364e0728e1935e11a0565ad8af1777a> (251) Patch Links: - https://github.com/MikePiper/open-social-security/pull/23.patch - https://github.com/MikePiper/open-social-security/pull/23.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#23>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AJMUXGLH3XT6OQ5SMNA55GDSHJ46VANCNFSM4RXTFOFQ> .