Add / Remove Multiple Choice Options #3951

lsabor · 2025-12-18T04:53:18Z

No description provided.

support null values on frontend fix flake8 complaints

add options_history field to question model and migration add options_history to question serialization add options_history initialization to question creation add helper functions to question/services/multiple_choice_handlers.py and add 'automatic' to forecast.source selection fix build_question_forecasts import and remove options & options_history from admin panel edit tests for question creation, multiple_choice_rename_option, multiple_choice_options_reorder, multiple_choice_delete_options, multiple_choice_add_options add options_history to openapi docs add csv reporting support for options_history update logic to play well with back/forward filling 0s add all_options_ever to serializer and api docs add current options to csv return add support for datetime isoformat in options_history

add options_history to question serialization add options_history initialization to question creation add helper functions to question/utils.py and add 'automatic' to forecast.source selection fix build_question_forecasts import and remove options & options_history from admin panel edit tests for question creation, multiple_choice_rename_option, multiple_choice_delete_options, multiple_choice_add_options add options_history to openapi docs add csv reporting support for options_history rebase to None openapi.py spelling update logic to play well with back/forward filling 0s update csv_utils update csv_utils 2 minor logic fix fix add all_options_ever to serializer and api docs add current options to csv return add support for datetime isoformat instead of timestamps in options_history move mc operations to mc handlers file move tests to appropriate locations minor cleanup fix forecast creation in test

fix file restructure fix datetime iso format in history conflicts other fixes mc/forecasts tweaks 2 mc forecasts tweaks 3 mc forecasts tweaks 4 mc forecasts tweaks 5 add support for None values in MC predictions fix tests and source logic

add options_history to question serialization add options_history initialization to question creation add helper functions to question/utils.py and add 'automatic' to forecast.source selection fix build_question_forecasts import and remove options & options_history from admin panel edit tests for question creation, multiple_choice_rename_option, multiple_choice_delete_options, multiple_choice_add_options add options_history to openapi docs add csv reporting support for options_history rebase to None openapi.py spelling update logic to play well with back/forward filling 0s update csv_utils update csv_utils 2 minor logic fix fix add all_options_ever to serializer and api docs add current options to csv return add support for datetime isoformat instead of timestamps in options_history move mc operations to mc handlers file move tests to appropriate locations minor cleanup fix forecast creation in test

parent 3c40ee2 author lsabor <[email protected]> 1763674087 -0800 committer lsabor <[email protected]> 1764534427 -0800 adjust aggregations to play nicely with placeholders improve test for comput_weighted_semi_standard_deviations add support for 0.0s in prediction difference for sorting plus tests update prediction difference for display to handle placeholders

parent 76bcb47 author lsabor <[email protected]> 1763312248 -0800 committer lsabor <[email protected]> 1764541784 -0800 add OptionsHistoryType, multiple_choice_interpret_forecast, and test update test for change to function update string_location_to_scaled_location to accept all historical option values, and related test multiple choice forecasts require interpretation before scoring remove double written definition support the new MC format scoring tests for mc with placeholder values add support for None values

add notification logic add mjml and update tasks to setup for notifications add withdrawal notifications and bulletin deactivation spelling of arg causes failure fix grace period end bug and skip emails

add admin form for changing options add comment author and text to admin panel action and mc change methods

forecast only current option values aggregation explorer disclaimer to forecast during grace period add option reordering (should be in mc/3804)

…aphing

ncarazon · 2026-01-05T07:12:03Z

front_end/src/components/forecast_maker/forecast_maker_question/forecast_maker_continuous.tsx

+      ? previousForecast.forecast_values.map((v) => {
+          if (v === null) {
+            throw new Error("Forecast values contain null values");
+          }
+          return v;
+        })


You do the mapping with the same behavior multiple times, better to extract it and reuse

ncarazon · 2026-01-05T07:12:52Z

...end/src/components/forecast_maker/forecast_maker_question/forecast_maker_multiple_choice.tsx

+  const [mounted, setMounted] = React.useState(false);
+
+  React.useEffect(() => {
+    setMounted(true);
+  }, []);


Suggested change

const [mounted, setMounted] = React.useState(false);

React.useEffect(() => {

setMounted(true);

}, []);

const [mounted, setMounted] = useState(false);

useEffect(() => {

setMounted(true);

}, []);

maybe let's create a reusable hook, sth like useIsMounted, as I see a lot of places where similar behavior is used

ncarazon · 2026-01-05T07:14:52Z

...end/src/components/forecast_maker/forecast_maker_question/forecast_maker_multiple_choice.tsx

+  const showOverlay =
+    showUserMustForecast && !dismissedOverlay && newOptions.length > 0;
+
+  const firstNewOptionRef = React.useRef<HTMLTableRowElement | null>(null);


Suggested change

const firstNewOptionRef = React.useRef<HTMLTableRowElement | null>(null);

const firstNewOptionRef = useRef<HTMLTableRowElement | null>(null);

ncarazon · 2026-01-05T07:16:10Z

...end/src/components/forecast_maker/forecast_maker_question/forecast_maker_multiple_choice.tsx

+  const NewOptionCallout: FC = () => {
+    const isPlural = newOptions.length > 1;
+    return (
+      <div className="mb-3 w-full rounded-lg bg-blue-900 p-4 shadow-lg dark:bg-blue-900-dark">
+        <p className="mb-2 mt-0 text-sm text-gray-0 dark:text-gray-0-dark">
+          {isPlural
+            ? "These options were recently added, please adjust your forecast(s) accordingly."
+            : "A new option was recently added, please adjust your forecasts accordingly."}
+        </p>
+        {isPlural && newOptions.length > 0 && mounted && (
+          <div className="mb-3 flex flex-wrap gap-4">
+            {newOptions.map((option) => (
+              <div key={option.name} className="flex items-center gap-1.5">
+                <div
+                  className="h-3 w-3 shrink-0 rounded-sm"
+                  style={{ backgroundColor: getThemeColor(option.color) }}
+                />
+                <span className="text-xs text-gray-0 dark:text-gray-0-dark">
+                  {option.name}
+                </span>
+              </div>
+            ))}
+          </div>
+        )}
+        <div className="flex gap-2">
+          <Button variant="secondary" size="sm" onClick={scrollToNewOptions}>
+            {isPlural ? "Show New Options" : "Show New Option"}
+          </Button>
+          <Button
+            variant="text"
+            size="sm"
+            className="text-gray-0 hover:text-gray-100 dark:text-gray-0-dark dark:hover:text-gray-100-dark"
+            onClick={() => setDismissedOverlay(true)}
+          >
+            Dismiss
+          </Button>
+        </div>
+      </div>
+    );
+  };
+


Let's not nest it inside another component and add translations

lsabor and others added 14 commits November 30, 2025 12:15

add support for None in forecast values

c734f33

support null values on frontend fix flake8 complaints

mc/3813/backend/forecasts

e3481d0

fix file restructure fix datetime iso format in history conflicts other fixes mc/forecasts tweaks 2 mc forecasts tweaks 3 mc forecasts tweaks 4 mc forecasts tweaks 5 add support for None values in MC predictions fix tests and source logic

mc/3802/backend/notifications

d408469

add notification logic add mjml and update tasks to setup for notifications add withdrawal notifications and bulletin deactivation spelling of arg causes failure fix grace period end bug and skip emails

mc/3804/backend/updating

10fa85f

add admin form for changing options add comment author and text to admin panel action and mc change methods

mc/3804/backend/updating

545cb4d

add admin form for changing options add comment author and text to admin panel action and mc change methods

mc/3805/frontend/graphing

d96663a

forecast only current option values aggregation explorer disclaimer to forecast during grace period add option reordering (should be in mc/3804)

Merge branch 'main' of github.com:Metaculus/metaculus into mc/3805/gr…

c2b1292

…aphing

Added tooltip and highlight for newly added MC options

417d978

Merge branch 'main' of github.com:Metaculus/metaculus into mc/3807/ui

6d7bde6

lsabor temporarily deployed to testing_env December 18, 2025 04:53 — with GitHub Actions Inactive

lsabor had a problem deploying to testing_env December 18, 2025 04:53 — with GitHub Actions Failure

lsabor temporarily deployed to play_env December 18, 2025 04:53 — with GitHub Actions Inactive

Updated highlight method and message copy

ba58cc1

aseckin temporarily deployed to testing_env December 29, 2025 17:16 — with GitHub Actions Inactive

aseckin had a problem deploying to testing_env December 29, 2025 17:16 — with GitHub Actions Failure

aseckin changed the title ~~Mc/3807/UI~~ Add / Remove Multiple Choice Options Dec 29, 2025

aseckin temporarily deployed to play_env December 29, 2025 17:17 — with GitHub Actions Inactive

aseckin requested a review from ncarazon December 29, 2025 17:34

aseckin temporarily deployed to play_env December 30, 2025 09:59 — with GitHub Actions Inactive

Merge branch 'main' into mc/3807/ui

980aab0

aseckin had a problem deploying to testing_env December 30, 2025 10:03 — with GitHub Actions Failure

aseckin temporarily deployed to testing_env December 30, 2025 10:03 — with GitHub Actions Inactive

lsabor deployed to play_env January 3, 2026 20:07 — with GitHub Actions Active

ncarazon requested changes Jan 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add / Remove Multiple Choice Options #3951

Add / Remove Multiple Choice Options #3951

Uh oh!

lsabor commented Dec 18, 2025

Uh oh!

ncarazon Jan 5, 2026

Uh oh!

ncarazon Jan 5, 2026

Uh oh!

ncarazon Jan 5, 2026

Uh oh!

ncarazon Jan 5, 2026

Uh oh!

ncarazon Jan 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const firstNewOptionRef = React.useRef<HTMLTableRowElement \| null>(null);
	const firstNewOptionRef = useRef<HTMLTableRowElement \| null>(null);

Add / Remove Multiple Choice Options #3951

Are you sure you want to change the base?

Add / Remove Multiple Choice Options #3951

Uh oh!

Conversation

lsabor commented Dec 18, 2025

Uh oh!

ncarazon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ncarazon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ncarazon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ncarazon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

ncarazon Jan 5, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants