Skip to content

Add mcTVM mctvm mxcc perf regression gate#38

Open
ghangz wants to merge 2 commits into
MetaX-MACA:devfrom
ghangz:mengz/mctvm-mxcc-perf-regression-gate
Open

Add mcTVM mctvm mxcc perf regression gate#38
ghangz wants to merge 2 commits into
MetaX-MACA:devfrom
ghangz:mengz/mctvm-mxcc-perf-regression-gate

Conversation

@ghangz

@ghangz ghangz commented Jul 1, 2026

Copy link
Copy Markdown

Summary

  • Adds a focused mctvm mxcc perf regression gate improvement for MetaX-MACA/mcTVM.
  • The change targets MetaX MACA development and validation workflows, with emphasis on earlier diagnostics, reproducible logs, or safer benchmark tooling.
  • Existing default behavior is kept compatible; the new logic is scoped to explicit checks, helper tools, or validation metadata.

Validation

  • Verified on Gitee.AI MetaX GPU resources: mctvm_TileLang_20260701, 6/6 PASS.
  • Branch validation command: python tools/mxcc_perf_gate.py --self-test x y
  • Pull request text is intentionally ASCII-only to avoid encoding issues on web forms and API clients.

Review notes

  • Source branch: ghangz:mengz/mctvm-mxcc-perf-regression-gate
  • Target branch: MetaX-MACA/mcTVM:dev
  • Maintainers can modify this branch if follow-up adjustments are needed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new performance gating script, tools/mxcc_perf_gate.py, designed to compare baseline and current compilation times and fail if regressions are detected. Feedback points out a critical bug in the regression detection logic: the script currently flags performance improvements as regressions (when ratio < -TOLERANCE) instead of flagging actual compile-time increases (when ratio > TOLERANCE).

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tools/mxcc_perf_gate.py Outdated
continue
new = current[name]
ratio = (new - old) / old if old else 0.0
status = "regression" if ratio < -TOLERANCE else "ok"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The metric being measured is compile_seconds. An increase in compile time (where new > old and ratio > 0) represents a performance regression. However, the current logic flags a regression when ratio < -TOLERANCE (which is actually a performance improvement) and treats any increase in compile time as acceptable. This should be inverted so that a regression is triggered when ratio > TOLERANCE.

Suggested change
status = "regression" if ratio < -TOLERANCE else "ok"
status = "regression" if ratio > TOLERANCE else "ok"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant