Skip to content

Add mcTVM quoted MACA path handling#36

Open
ghangz wants to merge 1 commit into
MetaX-MACA:devfrom
ghangz:mengz/mctvm-find-maca-quote-paths
Open

Add mcTVM quoted MACA path handling#36
ghangz wants to merge 1 commit into
MetaX-MACA:devfrom
ghangz:mengz/mctvm-find-maca-quote-paths

Conversation

@ghangz

@ghangz ghangz commented Jul 1, 2026

Copy link
Copy Markdown

Summary

  • This change makes FindMACA.cmake handle quoted MACA paths more safely, which avoids configure failures when toolchain paths contain shell-sensitive characters.
  • The change is limited to MACA build discovery or guarded setup logic and keeps existing default behavior compatible.
  • Main files: cmake/utils/FindMACA.cmake

Validation

  • Verified on Gitee.AI MetaX GPU resources in the mcTVM TileLang/MACA TVM build batch, 6/6 PASS.
  • Branch validation command: CMake configure and mxcc compile smoke validation in the MACA TVM build image.
  • Pull request text is ASCII-only to avoid encoding issues on web forms and API clients.

Review notes

  • Source branch: ghangz:mengz/mctvm-find-maca-quote-paths
  • Target branch: MetaX-MACA/mcTVM:dev
  • Maintainers can modify this branch if follow-up adjustments are needed.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates 'cmake/utils/FindMACA.cmake' by wrapping several variable and environment variable references in double quotes within 'IS_DIRECTORY' checks and path assignments. This is a standard CMake best practice to ensure paths containing spaces are handled correctly. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@ghangz ghangz changed the title Add mcTVM mctvm find MACA quote paths Add mcTVM quoted MACA path handling Jul 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant