Add mcTVM MACA lib64 discovery#35
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the MACA library search logic in FindMACA.cmake to look into multiple library paths (lib, lib64, and lib/x86_64-linux-gnu) and adds additional status messages. The review feedback recommends wrapping the library paths and message variable expansions in double quotes to ensure robustness when paths contain spaces.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| set(__maca_library_paths | ||
| ${__maca_sdk}/lib | ||
| ${__maca_sdk}/lib64 | ||
| ${__maca_sdk}/lib/x86_64-linux-gnu | ||
| ) |
There was a problem hiding this comment.
When defining list variables containing paths, it is important to wrap each path in double quotes. If ${__maca_sdk} contains spaces, the unquoted paths will be split into multiple list elements incorrectly, which can cause find_library to fail.
set(__maca_library_paths
"${__maca_sdk}/lib"
"${__maca_sdk}/lib64"
"${__maca_sdk}/lib/x86_64-linux-gnu"
)
| endif() | ||
| endif(__maca_sdk) | ||
| if(MACA_FOUND) | ||
| message(STATUS "Found MACA SDK=" ${__maca_sdk}) |
There was a problem hiding this comment.
To prevent issues when ${__maca_sdk} contains spaces (which would cause CMake to split it into multiple arguments and concatenate them without spaces in the output), it is safer and more idiomatic to wrap the variable expansion inside the double-quoted string.
message(STATUS "Found MACA SDK=${__maca_sdk}")
| message(STATUS "Found MACA SDK=" ${__maca_sdk}) | ||
| message(STATUS "Found MACA_INCLUDE_DIRS=" ${MACA_INCLUDE_DIRS}) | ||
| message(STATUS "Found MACA_MACAMCC_LIBRARY=" ${MACA_MACAMCC_LIBRARY}) | ||
| message(STATUS "Found MACA_HCA_LIBRARY=" ${MACA_HCA_LIBRARY}) |
Summary
Validation
Review notes