Skip to content

[Fix][Kernel] Fix fragment ownership in test_mamba.py - #62

Closed
guangxing83 wants to merge 6 commits into
MetaX-MACA:devfrom
guangxing83:dev-716ssd-chunk-scan
Closed

[Fix][Kernel] Fix fragment ownership in test_mamba.py#62
guangxing83 wants to merge 6 commits into
MetaX-MACA:devfrom
guangxing83:dev-716ssd-chunk-scan

Conversation

@guangxing83

@guangxing83 guangxing83 commented Jul 16, 2026

Copy link
Copy Markdown

Fix incorrect SSDChunkScanFwd results on MACA 64-lane warps by replacing four independent 32x32 loops with one 64x64 loop, ensuring consistent fragment ownership. This preserves the existing micro-block factorization without adding global-to-shared or global-to-fragment copies. Using a smaller tile also passes the tests but autotuning may still select an incorrect 64x64 configuration.

@github-actions github-actions Bot added the fix Auto-created by labeler label Jul 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the micro-block processing in tileops/kernels/mamba/ssd_chunk_scan.py by consolidating four separate parallel loops over M x M blocks into a single 2 * M x 2 * M parallel loop. This change ensures that a single full fragment domain is maintained, keeping ownership mapping consistent across both 32-lane and 64-lane GPU backends. Additionally, the variable anchor was renamed to micro_anchor. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@guangxing83
guangxing83 deleted the dev-716ssd-chunk-scan branch July 28, 2026 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Auto-created by labeler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant