Skip to content

[Fix][Kernel] Low-shared-memory fused prepare_wy_repr + compute_w_u k… - #57

Closed
guangxing83 wants to merge 4 commits into
MetaX-MACA:devfrom
guangxing83:dev
Closed

[Fix][Kernel] Low-shared-memory fused prepare_wy_repr + compute_w_u k…#57
guangxing83 wants to merge 4 commits into
MetaX-MACA:devfrom
guangxing83:dev

Conversation

@guangxing83

Copy link
Copy Markdown

Low-shared-memory fused prepare_wy_repr + compute_w_u kernel for ungated DeltaNet.

@github-actions github-actions Bot added the fix Auto-created by labeler label Jul 15, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new low-shared-memory fused kernel, fused_prepare_compute_w_u_tl_maca, for ungated DeltaNet in TileLang, replacing the previous implementation in deltanet_fwd.py. Feedback on the new kernel highlights critical race conditions in the repeated squaring loop due to missing thread synchronizations (T.sync_threads()). Additionally, it is recommended to enforce that the dynamically computed RHS tile size block_R is a multiple of 16 to ensure Tensor Core alignment and prevent performance degradation or compilation failures.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tileops/kernels/deltanet/fused_prepare_compute_w_u_maca.py
Comment thread tileops/kernels/deltanet/fused_prepare_compute_w_u_maca.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Auto-created by labeler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant