feat!: add time-based delay for first metrics sending #7624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
mikesposito
changed the title
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
7 tasks
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
Member
Author
|
@metamaskbot publish-previews |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Mrtenz
reviewed
Jan 16, 2026
| /** | ||
| * The default delay duration before data is sent for the first time, in milliseconds. | ||
| */ | ||
| export const DEFAULT_INITIAL_DELAY_DURATION = 10 * 60 * 1000; // 10 minutes |
Member
There was a problem hiding this comment.
We have a nice method in @metamask/utils for this:
Suggested change
| export const DEFAULT_INITIAL_DELAY_DURATION = 10 * 60 * 1000; // 10 minutes | |
| export const DEFAULT_INITIAL_DELAY_DURATION = inMilliseconds(10, Duration.Minute); |
Mrtenz
reviewed
Jan 16, 2026
| // it must have opted in during onboarding, or during a previous session. | ||
| this.skipInitialDelay(); | ||
| } | ||
| this.#queueFirstSyncIfNeeded().catch(console.error); |
Member
There was a problem hiding this comment.
Should this use messenger.captureException?
Member
Author
There was a problem hiding this comment.
Definitely, changed to this.messenger.captureException ?? console.error in a70fe32
Member
There was a problem hiding this comment.
messenger.captureException should always be defined in practice, so I think just using messenger?.captureException is ok, but this is fine too.
Member
Author
There was a problem hiding this comment.
It seems to be defined as optional:
core/packages/messenger/src/Messenger.ts
Line 263 in 0237820
Without using
console.error as fallback, I still get no-floating-promises errors
Mrtenz
approved these changes
Jan 16, 2026
mikesposito
deleted the
mikesposito/feat/delay-initial-metrics-sending
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
ProfileMetricsControlleris being overhauled to rely on a timestamp-based delay for the first sending of metrics, rather than waiting for a second App Unlock event. This change ensures that metrics are sent even if the user only unlocks the app once during a session.The delay is skipped immediately if:
KeyringController:unlockis fired (this covers both users who have opted-in in a previous session, and users who just onboarded and opted-in during onboarding)..skipInitialDelay()method or theProfileMetricsController:skipInitialDelayaction via messenger.References
Checklist
Note
Introduces a timestamp-based initial delay for first profile metrics send, with configurable duration and multiple skip paths.
initialDelayEndTimestampstate and default 10-minute delay; constructor acceptsinitialDelayDurationskipInitialDelay()method andProfileMetricsController:skipInitialDelayaction; auto-skip onKeyringController:unlockwhen already opted-in and onTransactionController:transactionSubmitted_executePollexits until delay completes; state metadata updated to persist/expose new fieldTransactionController:transactionSubmitted; add@metamask/transaction-controllerdependency and TS references; export new method-action types; tests and README dependency graph updatedWritten by Cursor Bugbot for commit 0237820. This will update automatically on new commits. Configure here.