fix: Ensure proper resolution of $ref references in path parameters#61
Open
romannekhor wants to merge 1 commit intoMermade:mainfrom
Open
fix: Ensure proper resolution of $ref references in path parameters#61romannekhor wants to merge 1 commit intoMermade:mainfrom
romannekhor wants to merge 1 commit intoMermade:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description
The
openapi-extracttool does not currently copy the contents of#/components/parameters/<param_name>when a$refis used at the#/paths/<path>/parameterslevel.Steps to Replicate the Problem
Using the following OpenAPI specification: PagerDuty API Schema.
Run the command:
This results in
#/components/parameters/idbeing referenced but not correctly copied into the final spec'scomponentsblock.Solution
This patch adds a
deref(...)call after cloning the path parameters block. This ensures that the$refreferences are properly resolved, resulting in a valid and complete spec file.