Update the R functions to allow outputting spending time #602
+113
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update `gs_design_ahr` to output spending time - update `summary` with a new argument to allow outputting spending time or not - update `as_gt`
jdblischak
reviewed
Dec 17, 2025
Collaborator
jdblischak
left a comment
jdblischak
left a comment
There was a problem hiding this comment.
I tested this locally. Overall looking good! To start I have some minor comments on how to organize the R code
Collaborator
|
The macOS build failed during the setup due to a known temporary problem (yihui/litedown#112). I restarted the build. |
Collaborator
|
The Ubuntu build with R-devel failed to build the vignette * creating vignettes ... ERROR
Error: --- re-building ‘gsDesign2.Rmd’ using rmarkdown
Quitting from gsDesign2.Rmd:123-133 [unnamed-chunk-5]
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
<error/rlang_error>
Error in `[.data.table`:
! attempt access index 6/6 in VECTOR_ELT
---
Backtrace:
▆
1. └─gsDesign2::fixed_design_ahr(...)
2. └─gsDesign2::gs_design_ahr(...) at gsDesign2/R/fixed_design_ahr.R:114:5
3. └─gsDesign2::gs_info_ahr(...) at gsDesign2/R/gs_design_ahr.R:228:3
4. ├─dplyr::select(...) at gsDesign2/R/gs_info_ahr.R:126:5
5. └─gsDesign2::ahr(...) at gsDesign2/R/gs_info_ahr.R:126:5
6. └─gsDesign2::pw_info(...) at gsDesign2/R/ahr.R:108:3
7. ├─tbl_event[, `:=`(info0, event * q_c * q_e), by = .(time)] at gsDesign2/R/pw_info.R:170:3
8. └─data.table:::`[.data.table`(...) at gsDesign2/R/pw_info.R:170:3
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: Error: processing vignette 'gsDesign2.Rmd' failed with diagnostics:
attempt access index 6/6 in VECTOR_ELT
--- failed re-building ‘gsDesign2.Rmd’
SUMMARY: processing the following file failed:
‘gsDesign2.Rmd’
Error: Error: Vignette re-building failed.The line that caused the failure hasn't been updated recently (nor has the surrounding code): Line 170 in ae1ed90 |
Collaborator
|
Both the macOS and Ubuntu builds passed on restart |
jdblischak
reviewed
Jan 2, 2026
|
|
||
| # Prepare the columns decimals ---- | ||
| default_decimals <- c(NA, NA, 2, if (method != "combo") 4, 4, 4, 4) | ||
| default_decimals <- c(NA, NA, 2, if (method != "combo") 4, 4, 4, 4, 4) |
Collaborator
There was a problem hiding this comment.
I think this extra 4 needs to be removed. IIUC it is optionally added below if display_spending_time is TRUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gs_design_ahrto output spending timesummarywith a new argumentdisplay_spending_timeto allow outputting spending time or not (default isFALSE)as_gt