Improve DIM performance using padding in FFT - #92
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #92 +/- ##
=======================================
Coverage 99.92% 99.92%
=======================================
Files 38 38
Lines 1304 1305 +1
=======================================
+ Hits 1303 1304 +1
Misses 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR aims to improve Direct Integration Method (DIM) propagation performance by allowing FFT-size padding in conv2d_fft, and enabling it in DIM.
Changes:
- Extend
conv2d_fftwith an extra FFT-size padding parameter and adjust FFT sizing logic. - Use
padding=1in DIM propagation to potentially get faster FFT sizes. - Add a new functional test covering a larger-kernel convolution scenario.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/functional/test_conv2d.py | Adds a new “large kernel” correctness test for conv2d_fft. |
| src/torchoptics/propagation/direct_integration_method.py | Enables FFT padding in DIM by calling conv2d_fft(..., padding=1). |
| src/torchoptics/functional/functional.py | Adds padding parameter to conv2d_fft and uses it to set FFT sizes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimize
conv2d()to improve performance for power-of-two grid shapes. Adds padding in FFT.Closes #68