Fix shared formula expansion for whole-row and whole-column references - #350
Open
JunWang-Lin wants to merge 2 commits into
Open
Fix shared formula expansion for whole-row and whole-column references#350JunWang-Lin wants to merge 2 commits into
JunWang-Lin wants to merge 2 commits into
Conversation
JunWang-Lin
marked this pull request as ready for review
July 25, 2026 00:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #349.
Summary
#REF!when an adjusted reference moves out of boundsRoot cause
Shared-formula expansion assumed every parsed reference had both a row and a column coordinate. Valid formulas such as
VLOOKUP(G3,A:B,2,FALSE)contain a whole-column reference with no row coordinate, so the expansion path unwrappedNoneand panicked.Validation
cargo +nightly fmtcargo clippy --lib -- -D warningscargo test(299 passed, 23 ignored)IF(G3="","",VLOOKUP(G3,A:B,2,FALSE))Note
The second commit restores a missing
}in the existingnumber_formatertest module on the current upstreammaster; without it, the repository cannot be formatted or compiled for validation.