Conversation
Improving on text cues and feature descriptions - fifth pass in order to avoid Yet Another PR, I browsed as much pages and checked as much UI elements as I could, went over the whole file again, cross compared with existing translation to make sure they made sense, fixed remaining text that could cause ambiguous translation works, some clearer text again & grammatical simplifications/fixes hopefully the last major revision, fingers crossed!
removing empty line
translations/en.json
Outdated
| "colors": { | ||
| "name": "Color count:", | ||
| "one": "One", | ||
| "one": "1", |
There was a problem hiding this comment.
I think using the actual words is better here
There was a problem hiding this comment.
about that, I -personally- don't like "one/two/three", I think a numerical selection would be better
BUT
I was considering submitting "monochrome/bicolor/tricolor", what do you think?
could submit that question to someone else maybe?
There was a problem hiding this comment.
I don't think having the actual numbers is fully ideal, though monochrome does not feel like the right word either. Though I'd be open for a discution somewhere else
There was a problem hiding this comment.
replaced monochrome with unicolor
There was a problem hiding this comment.
monochrome deffo feels more appropriate to me personally
There was a problem hiding this comment.
I think unicolor is worse, though I don't know what would be good
There was a problem hiding this comment.
IMHO, if an amount has to be described, then numbers (1, 2, 3) should be used
packing whole words in a drop down selector sounds unjustified
(especially when you have to account for the translation behind, why translate whole word numbers "just" for that?)
current : one, two, three
in PR : 1, 2, 3
alternative : unicolor, bicolor, tricolor
There was a problem hiding this comment.
yk what I've changed my mind, monochrome is fine
There was a problem hiding this comment.
yk what I've changed my mind, monochrome is fine
done :)
following first reviews of current PR
following second reviews of current PR
small patch for consistency in permission descriptions
attempt to resolve last reviews
following today's review from Mathium
3 participants
Description
Improving on text cues and feature descriptions - fifth pass
browsed as much pages and checked as much UI elements as I could all at once, went over the whole file again, cross compared with existing translation to make sure they fully made sense, some clearer text again, grammatical simplifications/fixes & some flavor edits too
in order to avoid Yet Another PR, hopefully the last major revision on this file, fingers crossed! 🤞😅👍