Split off the builtins-related part of distinct_arrangements.slt#34675
Merged
ggevay merged 1 commit intoMaterializeInc:mainfrom Jan 9, 2026
Merged
Split off the builtins-related part of distinct_arrangements.slt#34675ggevay merged 1 commit intoMaterializeInc:mainfrom
distinct_arrangements.slt#34675ggevay merged 1 commit intoMaterializeInc:mainfrom
Conversation
ggevay
force-pushed
the
split-distinct_arrangements.slt
branch
from
d0e11f9 to
69eed2d
Compare
def-
approved these changes
Jan 9, 2026
SangJunBak
pushed a commit
to SangJunBak/materialize
that referenced
this pull request
Jan 23, 2026
…rangements.slt Split off the builtins-related part of `distinct_arrangements.slt`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
distinct_arrangements.sltoften has to be rewritten when making changes to builtin views. However, it's very slow (because of the manysleeps due to waiting for introspection propagation), so it's not part of the normal CI, only Nightly, so it often gets forgotten. This PR splits off that part ofdistinct_arrangements.sltwhich is affected by builtin views into a new file, and makes this new file part of the normal CI, so that people (e.g., me) have no way to forget to rewrite it when changing a builtin view.