Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reorganizes where the “Official Website” entry point for Extensions lives by removing the main menu IBAction/storyboard menu item and reintroducing it as part of the Extensions window’s actions menu, with updated localization plumbing.
Changes:
- Removed the “Official Website” menu item/action from the main app menu and AppDelegate.
- Added an “Official Website” item to the Extensions window actions menu (with a centralized URL constant).
- Moved localization for “Official Website” from storyboard-extracted strings to the main string catalog, and updated the storyboard to add an icon for “Manage Extensions…”.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| MarkEditMac/Sources/Main/Application/AppDelegate+Menu.swift | Removes the openOfficialWebsite IBAction previously used by the main menu. |
| MarkEditMac/Sources/Extension/ExtensionsWindowController.swift | Adds the Official Website menu item to the Extensions window actions menu and centralizes the URL. |
| MarkEditMac/Sources/Extension/Core/ExtensionInstaller.swift | Introduces Localized.Extension.officialWebsite string for the new menu item. |
| MarkEditMac/Resources/Localizable.xcstrings | Adds the “Official Website” string entry and translations in the app string catalog. |
| MarkEditMac/mul.lproj/Main.xcstrings | Removes the storyboard-extracted localization entry for the deleted main-menu item. |
| MarkEditMac/Base.lproj/Main.storyboard | Removes the “Official Website” menu item from the Extensions main menu and adds an icon for “Manage Extensions…”. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.