Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the Extensions window’s empty/loading state behavior by distinguishing a cold start (no catalog loaded yet) from subsequent refreshes, and introduces a small animated empty-state view with an explicit retry action.
Changes:
- Add
hasLoadedIndextoExtensionsModeland set it once a registry index is successfully loaded. - Update the overlay logic to only show a spinner on cold start (
phase == .loading && !hasLoadedIndex), otherwise show the empty state (with retry on registry failure). - Ensure the AppKit view controller re-tracks model changes when
hasLoadedIndexupdates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| MarkEditMac/Sources/Extension/ExtensionsViewController.swift | Adds hasLoadedIndex to the observation tracking set so AppKit UI updates when the “catalog has ever loaded” state changes. |
| MarkEditMac/Sources/Extension/ExtensionsOverlays.swift | Refines loading vs empty-state presentation and adds a dedicated EmptyStateView with fade-in and retry wiring. |
| MarkEditMac/Sources/Extension/ExtensionsModel.swift | Introduces hasLoadedIndex and sets it when an index is present during item rebuilds. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.