Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures AppKit views are marked as needing layout before calling layoutSubtreeIfNeeded(), so that subsequent fittingSize/geometry reads reflect an up-to-date layout pass.
Changes:
- Mark
relaunchController.viewasneedsLayoutbefore measuringfittingSize.heightfor the relaunch info bar. - Mark
tableViewasneedsLayoutbefore forcing layout during category scrolling to ensure accurate row geometry. - Mark a temporary
NSHostingController’s view asneedsLayoutbefore measuring a SwiftUIView’sfittingSizein the text completion module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| MarkEditMac/Sources/Extension/ExtensionsViewController.swift | Ensures relaunch bar height measurement and scroll-to-row geometry are based on a freshly-dirtied layout pass. |
| MarkEditMac/Modules/Sources/TextCompletion/Extensions/View+Extension.swift | Ensures SwiftUI view size measurement runs a layout pass by marking the hosting view dirty before measuring. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.