Fix: SISR residual block architecture and optimize forward pass #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a critical logic error in the
SISRmodel's residual layers and optimizes memory usage during the forward pass.Changes
Critical Fix: Removed the final
ReLUactivation inmake_residual_layer.x + Residual(x). If the residual path ends in a ReLU, it can only add positive values to the signal, severely limiting the network's capacity to learn.Optimization: Removed
x.clone()calls in theforwardmethod.Refactoring: Updated
super(SISR, self).__init__()to the modern Python 3super().__init__()syntax.