Fix: directory creation crash and replace !tree with portable python #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR improves the stability of the setup phase in the Archil_Srivastava Classification Transformers module by replacing fragile shell commands and fixing directory handling.
Key Changes
1.Idempotency: Added exist_ok=True to os.makedirs for
SAVEPATHandCKP_PATH. This preventsFileExistsError [WinError 183]when re-running the setup cells.2.Cross-Platform Tree Visualization: Replaced the shell-dependent !tree command with a pure-Python recursive function. This ensures that the directory structure can be inspected on Windows, macOS, and Linux without external dependencies.
3.Path Robustness: Standardized directory definitions using os.path.join to prevent path-separator conflicts.
Verification
1.Tested on Windows 11: The script now successfully skips directory creation if folders exist and correctly prints the file tree.
2.Tested repeated execution: No longer throws
FileExistsError.