Skip to content

Fix primal scale bug in compute residual #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
LucasBoTang wants to merge 12 commits into from
Closed

Fix primal scale bug in compute residual #78

LucasBoTang wants to merge 12 commits into from

Conversation

@LucasBoTang
Copy link
Collaborator

@LucasBoTang LucasBoTang commented Feb 4, 2026 •
edited
Loading

The place of

state->absolute_primal_residual /= state->constraint_bound_rescaling;

in compute_residual seems wrong.

@ZedongPeng
Copy link
Collaborator

ZedongPeng commented Feb 5, 2026

Yeah. This is a bug that will only be triggered in the L_INF norm.

@ZedongPeng
Copy link
Collaborator

ZedongPeng commented Feb 7, 2026

Let's create a new PR.

@ZedongPeng ZedongPeng closed this Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LucasBoTang @ZedongPeng