Fix AMD Occlusion Culling (Read-Side Hack) - Fixes #179#221
Open
1MarcosDev wants to merge 1 commit into
Open
Conversation
Owner
|
Thank you, would you first be able to check that https://github.com/MCRcortex/voxy/blob/dev/src/main/java/me/cortex/voxy/client/core/gl/Capabilities.java#L104 this can correctly identify broken cards, secondly please see the comment here #179 (comment) about issues with this fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Reopened on the correct branch.)
This is a fixer I've been testing that fixes a rendering bug on older AMD graphics cards and integrated graphics.
I've created a document and conducted user tests in this thread.
From the beginning, I believed that this alone wouldn't be enough to make the mod compatible and stable with all graphics cards, since it's practically a fixer made specifically for my GPU, the RX 580, although some users are reporting it working on other GPUs.
I also don't know how much this affects the mod's performance and stability, but according to user tests, it wasn't affected.
This pull request is mainly intended to get this to you faster and help you get an idea of how to bring support for these graphics cards in future updates.