Add switch to disable custom Skin URL Connection (--disableSkinFix).#35
Add switch to disable custom Skin URL Connection (--disableSkinFix).#35Jade-TheCat wants to merge 2 commits intoMCPHackers:mainfrom
Conversation
…This enables use of the Betacraft Proxy for custom legacy skins.
|
Updated the PR to fix #36 as well since I found the problem I think |
|
You could use Betacraft directly by switching the URLs over to Can't say anything for the latter as it is hard to review on phone. |
|
An alternative implementation to consider is disabling skinfix and other proxied requests when a proxy is enabled. Just my 2 cents, Lassebq has a better understanding of LW than I do. |
|
Can you remind me please, does -Dhttp.proxyHost=betacraft.uk take presence over LaunchWrapper's skinfix? Or does it not work at all? |
|
As an aside, signature changes for methods require a version bump (as it is the same as deleting a method and making a new one). To be honest, the old method should probably be preserved with |
|
Using the proxy with LaunchWrapper causes an error and the skin fails to
load entirely. This is because the proxy only works for the old style of
skin fetching and not the modern way used in LW.
I also talked to a dev of Betacraft and they said they are planning to have
an API at some point for getting their custom skins. So when that happens
I'll put in a PR to add support like the other skin services already
supported by LW.
For now being able to use the proxy with LW is the only option though.
…On Mon, Dec 29, 2025 at 2:09 AM Zero_DSRS_VX ***@***.***> wrote:
*PhoenixVX* left a comment (MCPHackers/LaunchWrapper#35)
<#35 (comment)>
As an aside, signature changes for methods require a version bump (as it
is the same as deleting a method and making a new one). To be honest, the
old method should probably be preserved with @deprecated on it as a
just-in-case any old code uses it.
—
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB7PZUCPE32IJU2OXQDUEM34EDOSBAVCNFSM6AAAAACQC6UAC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMOJVG44TANZWG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
3 participants
This enables use of the Betacraft Proxy for custom legacy skins.
I use a custom skin on the Betacraft Proxy in order to have a separate skin for older versions, so this will allow the usage of that proxy. There might be a better way to do this by calling Betacraft directly, but I don't know how one would even do that. There doesn't seem to be any documentation on the website for that, so I am currently assuming that is impossible without going through the HTTP proxy.