Skip to content

Copy built album-embed assets into Docker images#4084

Merged
ildyria merged 1 commit intoLycheeOrg:masterfrom
cdzombak:cdz-fix-embed-build
Feb 12, 2026
Merged

Copy built album-embed assets into Docker images#4084
ildyria merged 1 commit intoLycheeOrg:masterfrom
cdzombak:cdz-fix-embed-build

Conversation

@cdzombak
Copy link
Contributor

@cdzombak cdzombak commented Feb 12, 2026

The album/stream embed widget is built to public/embed/ (which is .gitignored) but only public/build/ was copied from the node build stage. This caused embedded albums to be broken in Lychee 7.x.

Summary by CodeRabbit

  • Chores
    • Updated Docker image configurations to include embedding assets in production builds. Assets from public/embed are now available at runtime alongside existing public build assets, improving asset delivery capabilities.

The embed widget is built to public/embed/ (which is .gitignored) but
only public/build/ was copied from the node build stage. This caused
/embed/lychee-embed.js to fall through to Laravel routing instead of
being served as a static file.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@cdzombak cdzombak requested a review from a team as a code owner February 12, 2026 19:45
@coderabbitai
Copy link

coderabbitai bot commented Feb 12, 2026

📝 Walkthrough

Walkthrough

Both Dockerfile and Dockerfile-legacy are updated to copy the public/embed directory from the build stage to the final production image. This makes embedded assets available alongside existing public build assets during container runtime.

Changes

Cohort / File(s) Summary
Docker Build Configuration
Dockerfile, Dockerfile-legacy
Added COPY instruction to include public/embed assets from the node build stage into the final production image.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A rabbit hops through layers so neat,
Embedding assets, what a treat!
From node stage to prod, they fly,
Public/embed reaches the sky! 🚀

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into master

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


No actionable comments were generated in the recent review. 🎉


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cdzombak
Copy link
Contributor Author

cdzombak commented Feb 12, 2026

FWIW, this commit is currently built & deployed to https://pictures.dzombak.com; a working embedded album is visible at https://www.dzombak.com/blog/2026/02/birds-of-sanibel-island/ .

@ildyria ildyria enabled auto-merge (squash) February 12, 2026 19:56
@ildyria ildyria merged commit fa619ee into LycheeOrg:master Feb 12, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants