Skip to content

feat: team owner can create private:admin access token#3039

Closed
msmithstubbs wants to merge 3 commits into
Logflare:mainfrom
msmithstubbs:ui/create-admin-token
Closed

feat: team owner can create private:admin access token#3039
msmithstubbs wants to merge 3 commits into
Logflare:mainfrom
msmithstubbs:ui/create-admin-token

Conversation

@msmithstubbs

@msmithstubbs msmithstubbs commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

UI to allow team owner can create a private:admin access token.

CleanShot 2025-12-15 at 10 45 08@2x

This PR is the UI only. Access control for this token will be a subsequent PR.

Part of ANL-1251

@msmithstubbs msmithstubbs force-pushed the ui/create-admin-token branch 2 times, most recently from 7049aa6 to b37a048 Compare December 15, 2025 01:35
@msmithstubbs msmithstubbs marked this pull request as ready for review December 15, 2025 03:57
Comment thread lib/logflare/teams/team_context.ex Outdated
def parse_team_id(_), do: {:error, :invalid_team_id}

def team_owner?(%__MODULE__{team: team, user: user, team_user: nil}),
do: team_owner?(team, user.email)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we collocate the functions for better readability please

Comment thread lib/logflare/teams/team_context.ex Outdated

def parse_team_id(_), do: {:error, :invalid_team_id}

def team_owner?(%__MODULE__{team: team, user: user, team_user: nil}),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs spec

@msmithstubbs

Copy link
Copy Markdown
Contributor Author

closing, now part of #3040

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants