fix: Add null-checks for tenant.id before force unwrap#174
Open
Lionhunt3r wants to merge 1 commit into
Open
Conversation
- people_list_page.dart: Check tenant.id != null before .eq() query - person_detail_page.dart: Check tenant.id != null in personProvider - person_detail_page.dart: Extract criticalRules to local variable for clarity - late_warning_card.dart: Extract criticalRules to local variable for clarity Prevents potential crash when tenant.id is null. Closes #162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tenant.idbefore force unwrap to prevent crashescriticalRulesto local variables for better code clarityChanges
people_list_page.dart: Checktenant.id != nullbefore.eq()queryperson_detail_page.dart: Checktenant.id != nullin personProviderperson_detail_page.dart: Extract criticalRules to local variablelate_warning_card.dart: Extract criticalRules to local variableTest plan
Closes #162