Skip to content

fix(doctor): keep diagnostics running on malformed state - #882

Merged
huangzesen merged 1 commit into
Lingtai-AI:mainfrom
TZZheng:fix/issue-748-doctor-keep-going-telegrambot
Jul 24, 2026
Merged

fix(doctor): keep diagnostics running on malformed state#882
huangzesen merged 1 commit into
Lingtai-AI:mainfrom
TZZheng:fix/issue-748-doctor-keep-going-telegrambot

Conversation

@TZZheng

@TZZheng TZZheng commented Jul 12, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • import Iterable so runtime type-hint resolution does not fail
  • replace assertion-based crashes on malformed-but-valid JSON shapes with structured diagnostic findings
  • catch addon probe subprocess.TimeoutExpired errors and continue the remaining checks
  • add focused regressions for all three keep-going failure modes

Validation

  • PYTHONPATH=src python -m pytest -q tests/test_lingtai_doctor.py5 passed
  • git diff --check canonical/main...HEAD — passed
  • independent read-only review — PASS, no blockers

Risk

The doctor now reports these failures instead of terminating early. The change is confined to diagnostic error handling and preserves successful probe behavior.

Fixes #748

@huangzesen
huangzesen force-pushed the fix/issue-748-doctor-keep-going-telegrambot branch 2 times, most recently from 1ffd483 to 6e3fea2 Compare July 23, 2026 08:55
@huangzesen
huangzesen force-pushed the fix/issue-748-doctor-keep-going-telegrambot branch from 6e3fea2 to 65e86ce Compare July 24, 2026 04:54
@huangzesen
huangzesen merged commit e7b5f66 into Lingtai-AI:main Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lingtai-doctor: crash paths (missing Iterable import, isinstance asserts, uncaught subprocess timeout) defeat its keep-going diagnostic contract

2 participants