Skip to content

Conversation

@jmlarson1
Copy link
Member

One of many features of APOSMM being tested by this test was the ability to stop after k local minima have been identified.

This was set to 25 before and was sufficient to find all 6 local minima in less than 1000 sim evals.

Due to updates to NLopt, this is no longer the case: 1000 evals are surpassed before 25 minima are found.

Decreasing the 25 to 15 fixes the issue, and also still finds all 6 of the 6-hump-camel minima.

@jmlarson1 jmlarson1 requested a review from jlnav November 18, 2024 19:31
@jmlarson1 jmlarson1 changed the base branch from main to develop November 19, 2024 20:38
@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.30%. Comparing base (0e1dc6c) to head (3a24091).
Report is 99 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1469      +/-   ##
===========================================
+ Coverage    69.18%   78.30%   +9.11%     
===========================================
  Files           76       76              
  Lines         7679     7679              
  Branches      1139     1139              
===========================================
+ Hits          5313     6013     +700     
+ Misses        2177     1468     -709     
- Partials       189      198       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jlnav jlnav merged commit 7ad9f25 into develop Nov 20, 2024
13 of 15 checks passed
@jmlarson1 jmlarson1 deleted the bugfix/nlopt_changes branch February 20, 2025 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants