Skip to content

fix ASMRemapperTransformer - #70

Merged
ah-OOG-ah merged 1 commit into
LegacyModdingMC:masterfrom
danyadev:fix-ASMRemapperTransformer
May 11, 2026
Merged

fix ASMRemapperTransformer#70
ah-OOG-ah merged 1 commit into
LegacyModdingMC:masterfrom
danyadev:fix-ASMRemapperTransformer

Conversation

@danyadev

@danyadev danyadev commented May 8, 2026

Copy link
Copy Markdown
Contributor

fixes #69 (nice)

  1. changed class reader & writer flags back to COMPUTE_MAXS & EXPAND_FRAMES, which fixes the main issue
  2. switched from ClassConstantPoolParser to my own BytePatternMatcher, which allows to match substrings, and started searching for substrings with asm package paths instead of matching only entries which start from these paths. I.e. now we can match Lorg/objectweb/asm/tree/ClassNode; arguments inside method signatures. Just in case someone creates a method with a specific ASM package in arguments instead of the default org.objectweb.asm one. Because if we won't replace them we won't be able to pass our desired ASM package. That was the default behavior before my initial PR either way

@mitchej123
mitchej123 requested a review from a team May 9, 2026 03:36
@ah-OOG-ah
ah-OOG-ah merged commit c47090b into LegacyModdingMC:master May 11, 2026
1 check passed
@danyadev
danyadev deleted the fix-ASMRemapperTransformer branch May 12, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible regression in ASMRemapperTransformer in UniMixins 0.3.0

3 participants