Conversation
fix: security hardening for admin rotation, dispute resolution, and clawback Lead-Studios#277: resolve_dispute now calls require_auth() as first statement before any storage reads to prevent unauthorized resolution attempts Lead-Studios#276: Add guard to prevent clawback from contract address in both clawback and clawback_batch functions to protect escrow/split funds held by contract Lead-Studios#287: Add tests verifying old admin cannot perform admin actions after rotation - confirms admin powers are properly revoked Lead-Studios#275: Document recurring payment pull model - funds not locked at setup so no refund needed on cancellation; add test confirming payer balance preserved ```
|
@Spycall Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
BigBen-7
approved these changes
Jun 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: security hardening for admin rotation, dispute resolution, and clawback
#277: resolve_dispute now calls require_auth() as first statement before any storage reads to prevent unauthorized resolution attempts
#276: Add guard to prevent clawback from contract address in both clawback and clawback_batch functions to protect escrow/split funds held by contract
#287: Add tests verifying old admin cannot perform admin actions after rotation - confirms admin powers are properly revoked
#275: Document recurring payment pull model - funds not locked at setup so no refund needed on cancellation; add test confirming payer balance preserved
Closes #277
Closes #276
Closes #287
Closes #275