Add support for Konsole#193
Open
PrimaryCanary wants to merge 4 commits into
Open
Conversation
Author
|
Pinging @sylveon to get some eyes on this. |
Collaborator
|
I don't use Linux anymore so I can't validate this - somebody like @samuelhnrq would probably be better |
Collaborator
|
Sorry people, been busy with my job lately, will try to test it this week. Does this implementation need integration with plasma or Konsole running on gnome would be enough for testing? |
Author
|
I only tested on Plasma. It will work as long as ~/.local/share/konsole/Pokemon.colorscheme exists and is a valid colorscheme or link to a valid colorscheme.Nov 24, 2020, 05:04 by notifications@github.com:
…
Sorry people, been busy with my job lately, will try to test it this week. Does this implementation need integration with plasma or Konsole running on gnome would be enough for testing?
—
You are receiving this because you authored the thread.
Reply to this email directly, > view it on GitHub <#193 (comment)>> , or > unsubscribe <https://github.com/notifications/unsubscribe-auth/AK7RIMLUZ3LVCD3NII6K6W3SROOOTANCNFSM4TOBS42A>> .
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code isn't great but it works well enough in my testing.
I didn't see these issues when I started but fixes #181 and part of #192.