Skip to content

test(proxy): cover storage config parsing#2525

Open
reflecttypefor wants to merge 1 commit into
Layr-Labs:masterfrom
reflecttypefor:master
Open

test(proxy): cover storage config parsing#2525
reflecttypefor wants to merge 1 commit into
Layr-Labs:masterfrom
reflecttypefor:master

Conversation

@reflecttypefor

@reflecttypefor reflecttypefor commented Jun 18, 2026

Copy link
Copy Markdown

Why are these changes needed?

This adds coverage for proxy storage CLI configuration parsing. In particular, it verifies that the storage config defaults to the V2 backend, preserves empty cache/fallback target filtering, and rejects an empty backend list after filtering empty values.

The backend parsing path now filters empty backend entries before validation, matching the existing behavior for cache and fallback targets.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.

  • I've checked the new test coverage and the coverage percentage didn't drop.

  • Testing Strategy

    • Unit tests
    • Integration tests
    • This PR is not tested :(
  • go test ./api/proxy/store -count=1

  • go test $(go list ./api/proxy/... | grep -v '/api/proxy/test') -count=1

go test ./api/proxy/... -count=1 was not fully runnable locally because api/proxy/test/... requires Docker/testcontainers and failed with rootless Docker not found.

Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant