test(proxy): cover storage config parsing#2525
Open
reflecttypefor wants to merge 1 commit into
Open
Conversation
Signed-off-by: reflecttypefor <reflecttypefor@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This adds coverage for proxy storage CLI configuration parsing. In particular, it verifies that the storage config defaults to the V2 backend, preserves empty cache/fallback target filtering, and rejects an empty backend list after filtering empty values.
The backend parsing path now filters empty backend entries before validation, matching the existing behavior for cache and fallback targets.
Checks
I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
I've checked the new test coverage and the coverage percentage didn't drop.
Testing Strategy
go test ./api/proxy/store -count=1go test $(go list ./api/proxy/... | grep -v '/api/proxy/test') -count=1go test ./api/proxy/... -count=1was not fully runnable locally becauseapi/proxy/test/...requires Docker/testcontainers and failed withrootless Docker not found.