fix: verify all adjacent certificate chain links in browser MDA validation#130
Open
antojoseph wants to merge 2 commits into
Open
fix: verify all adjacent certificate chain links in browser MDA validation#130antojoseph wants to merge 2 commits into
antojoseph wants to merge 2 commits into
Conversation
…ation Previously only verified leaf→certs[1] and topCert→AppleRoot, leaving intermediate links unchecked. A crafted chain [forged_leaf, attacker_CA, Apple_root] would pass both checks without attacker_CA being signed by Apple root. Now iterates all adjacent pairs before accepting the chain.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hankbobtheresearchoor
approved these changes
May 4, 2026
Contributor
hankbobtheresearchoor
left a comment
hankbobtheresearchoor
left a comment
There was a problem hiding this comment.
LGTM. This closes the browser-side MDA chain gap by checking each adjacent certificate signature before the Apple root check.
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
|
Deployment failed with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
Benchmark ResultsRunner: 1-provider-streaming1 providers, 1 users, 30 requests, concurrency=5, streaming=true
Latency Decomposition
Assertion Report: PASS
1-provider-non-streaming1 providers, 1 users, 20 requests, concurrency=5, streaming=false
Latency Decomposition
Assertion Report: PASS
7-provider-multi-model7 providers, 5 users, 50 requests, concurrency=10, streaming=true
Latency Decomposition
Assertion Report: PASS
3-provider-high-concurrency3 providers, 10 users, 60 requests, concurrency=20, streaming=true
Latency Decomposition
Assertion Report: PASS
1-provider-queue-saturation1 providers, 10 users, 40 requests, concurrency=15, streaming=true
Latency Decomposition
Assertion Report: PASS
3-provider-20-users3 providers, 20 users, 60 requests, concurrency=10, streaming=true
Latency Decomposition
Assertion Report: PASS
1-provider-scaling1 providers, 5 users, 30 requests, concurrency=10, streaming=true
Latency Decomposition
Assertion Report: PASS
3-provider-scaling3 providers, 5 users, 30 requests, concurrency=10, streaming=true
Latency Decomposition
Assertion Report: PASS
5-provider-scaling5 providers, 5 users, 30 requests, concurrency=10, streaming=true
Latency Decomposition
Assertion Report: PASS
3-provider-heavy-100conc-10kb3 providers, 20 users, 100 requests, concurrency=100, streaming=true
Latency Decomposition
Assertion Report: FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console-ui/src/lib/cert-verify.ts: step 3 now iterates all adjacent pairscerts[i].verify(certs[i+1])instead of only checkingleaf → certs[1]Security impact
The previous code only verified that the leaf was signed by
certs[1], and separately that the topmost cert was signed by Apple's root. A crafted chain like[forged_leaf, attacker_CA, Apple_root]— whereforged_leafis signed byattacker_CAandattacker_CAis self-signed — would pass both checks withoutattacker_CAbeing validated againstApple_root. The fix closes this gap by verifying every link in the chain before accepting it.This is a client-side verification displayed in the UI's "Verify Device" panel, so exploitation requires serving a forged cert chain to a user who clicks "Verify."
Test plan
npx tsc --noEmit— no new type errors in cert-verify.ts