fix: return verification failure when Apple root CA is nil in MDA cert chain#126
Open
antojoseph wants to merge 1 commit into
Open
fix: return verification failure when Apple root CA is nil in MDA cert chain#126antojoseph wants to merge 1 commit into
antojoseph wants to merge 1 commit into
Conversation
VerifyMDACertChain previously set result.Valid=true even when appleRootCA was nil, meaning a self-signed cert passed through unverified. Any caller that passed nil got a 'valid' result with no chain verification at all. Now: a nil root CA returns Valid=false with an explanatory error. DeviceSerial is still populated so callers can log the device identity. The test that previously locked in the insecure behavior is updated to match.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mda.go: whenappleRootCA == nil(the pool contains no root cert), returnValid=falsewith a descriptive error instead of silently falling through toValid=truemda_test.go: updatedTestVerifyMDACertChainNilRootto assertValid=falseSecurity impact
Before this fix an attestation request with a crafted cert chain could pass MDA verification when the Apple root CA pool was empty (e.g., cert file missing or misconfigured), granting
mda_verifiedtrust to an unattesteddevice. The fix ensures an empty root pool is a hard failure.Test plan
go test ./internal/attestation/...TestVerifyMDACertChainNilRootnow passes (was asserting wrong direction)